{{ message }}
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
[WIP] Add FilePatch-header#479
Closed
simurai wants to merge 1 commit into
Closed
Conversation
Contributor
Author
Contributor
|
Hmm those are all good points @simurai. I do like the open file and view staged/unstaged version affordances. We could also add buttons for stage/unstage all, discard all, and undo discard. What do you think about keeping the bar just for these? |
Contributor
This was referenced Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a header to the FilePatch view. It could be used to add some more infos or buttons.
Concerns
Overkill? For example the toggle might makes it feel more complicated than it should be. Having to pay attention to what mode you're in. Switching between staged/unstaged changes without having to find it in the list sounds useful though.