{{ message }}
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Rename CSS classes from git -> github#372
Merged
Merged
Conversation
smashwilson
suggested changes
Dec 15, 2016
smashwilson
left a comment
smashwilson
left a comment
Contributor
There was a problem hiding this comment.
Looking good 👍
I tracked down the CI failure, but I'd ❤️ to get this merged quickly so that we can deal with conflicts in our other branches sooner rather than later.
Isn't it fun when we all work on sweeping changes that touch the entire package at once 😉
Contributor
There was a problem hiding this comment.
It looks like this line is just over the maximum line length for eslint:
> eslint --max-warnings 0 test lib
/Users/travis/build/atom/github/lib/views/commit-view.js
112:1 warning Line 112 exceeds the maximum line length of 120 max-len
smashwilson
approved these changes
Dec 15, 2016
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the namespace of all the CSS classes from
gittogithub. So that it matches the package name.Conflicts
This PR probably conflicts with:
CI fail
Unrelated?
ESLint found too many warnings (maximum: 0).