Clarify debug line by icecream17 · Pull Request #2682 · atom/github · GitHub
Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Clarify debug line - #2682

Merged
smashwilson merged 1 commit into
atom:masterfrom
icecream17:clarify-debug
May 14, 2021
Merged

smashwilson merged 1 commit into
atom:masterfrom
icecream17:clarify-debug

Conversation

@icecream17

Copy link
Copy Markdown

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

Description of the Change

Clarify a debug statement - I saw this and thought somehow atom used up 4999 requests (resets in a hour doesn't help either)

Screenshot or Gif

Original:
image

New:
image

Maybe there's a better way to format this, but I haven't found it

Applicable Issues

@smashwilson smashwilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 works for me. Thanks!

I'll merge as soon as I can get CI to run. (Our CI isn't in a great state on this repository... there will likely be unrelated failures I'm afraid.)

@smashwilson

Copy link
Copy Markdown
Contributor

@smashwilson
smashwilson merged commit cb4a0f7 into atom:master May 14, 2021
@icecream17
icecream17 deleted the clarify-debug branch May 17, 2021 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants