{{ message }}
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
Update shell.openExternal to promise due to electron update on atom - #2625
Merged
Merged
Conversation
sadick254
force-pushed
the
update-electron-apis
branch
2 times, most recently
from
February 11, 2021 06:23
ecf308b to
d08bb7b
Compare
smashwilson
reviewed
Feb 11, 2021
smashwilson
left a comment
smashwilson
left a comment
Contributor
There was a problem hiding this comment.
Hmm CodeCov is complaining about these... they must not be covered by existing tests. I think that's probably not worth addressing here, though, because these methods don't do anything but call two other functions that we'd need to stub anyway.
Contributor
|
Looks like we'll need to update the stubbing in some tests, too. |
sadick254
force-pushed
the
update-electron-apis
branch
4 times, most recently
from
February 12, 2021 07:09
5e165e6 to
9678921
Compare
sadick254
force-pushed
the
update-electron-apis
branch
from
February 12, 2021 16:27
9678921 to
4ab44f3
Compare
smashwilson
approved these changes
Feb 12, 2021
Contributor
There was a problem hiding this comment.
I think these could also be .returns(Promise.resolve()). No big deal though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
There are some Electron APIs that changed to only return Promises (and not run callbacks passed to them), mostly as of Electron 7+. Updating to be compatible with those would be great for updating Atom's Electron version.
Screenshot or Gif
Applicable Issues
#2624