{{ message }}
This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Repository navigation
fix: require .node files directly to detect incompatible native modules - #21927
Merged
darangi merged 2 commits intoMar 13, 2021
Merged
Conversation
aminya
commented
Feb 4, 2021
aminya
force-pushed
the
incompatible-native-detection
branch
4 times, most recently
from
February 4, 2021 06:33
de30f5e to
ec3f95e
Compare
aminya
force-pushed
the
incompatible-native-detection
branch
from
March 6, 2021 06:20
ec3f95e to
afaceb3
Compare
- This fixes the incompatible native module detection for the packages that require their .node files lazily - Speeds up the performance of detection by directly require .node files instead of requiring the package
aminya
force-pushed
the
incompatible-native-detection
branch
from
March 6, 2021 06:56
afaceb3 to
ad2aaa8
Compare
Contributor
Author
58 tasks done
|
The support burden of each electron upgrade breaking current installs would be greatly alleviated by this PR, so thx at @aminya for these efforts. |
Contributor
|
Thanks for the effort 🎉 @aminya |
Contributor
Author
|
You're welcome! |
1 task done
|
Congrats on merge, if this is backported into 1.56beta we may have some joy out of this sooner rater than later. |
|
So apparently atom 1.56.0 doesn't include this fix see https://github.com/bus-stop/terminus/issues/219 could it be backported to next 1.56 release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
fix: require .node files directly to detect incompatible native modules
.nodefiles lazilyFixed Issues
This bug is one of the reasons that all the terminal packages break whenever an Electron upgrade happens or when you don't use
apm rebuildAn example of the packages that get fixed by this fix:
All the terminal packages that use
node-pty-prebuilt-multiarch. Among them:There are many other issues. I need time to list all of them
Verification
The CI passes.
A test you can do:
npm rebuildin its directory under.atom/packages/x-terminal