Add a way to do reprojection without dumping dask arrays to memory maps and switch default for reproject_interp to not write to memory maps by astrofrog · Pull Request #532 · astropy/reproject · GitHub
Skip to content

Add a way to do reprojection without dumping dask arrays to memory maps and switch default for reproject_interp to not write to memory maps#532

Merged
astrofrog merged 10 commits into
astropy:mainfrom
astrofrog:dask-native-reproject
Nov 13, 2025
Merged

Add a way to do reprojection without dumping dask arrays to memory maps and switch default for reproject_interp to not write to memory maps#532
astrofrog merged 10 commits into
astropy:mainfrom
astrofrog:dask-native-reproject

Conversation

@astrofrog

Copy link
Copy Markdown
Member

Very much just work in progress, not ready for testing

@codecov

codecov Bot commented Jul 10, 2025

Copy link
Copy Markdown

@astrofrog astrofrog force-pushed the dask-native-reproject branch from e29a834 to 4f87347 Compare November 12, 2025 10:17
@astrofrog astrofrog force-pushed the dask-native-reproject branch from af19c07 to 1eba27d Compare November 12, 2025 14:39
@astrofrog

Copy link
Copy Markdown
Member Author

This seems to work - the main question now will be whether to rename the 'none' option or change the keyword argument to memmap_dask=True/False for clarity.

@astrofrog astrofrog changed the title WIP: add a way to do reprojection without dumping dask arrays to memory maps Add a way to do reprojection without dumping dask arrays to memory maps and switch default for reproject_interp to not write to memory maps Nov 12, 2025
@astrofrog astrofrog marked this pull request as ready for review November 13, 2025 11:23
@astrofrog

Copy link
Copy Markdown
Member Author

@Cadair @svank this adds a dependency on a very recent version of dask-image, which means also bumping the minimum dask version to one that is around a year old. I don't really foresee issues with this since pip/conda should just do their thing when people install reproject, but let me know if you are opposed to adding this dependency.

@Cadair

Cadair commented Nov 13, 2025

Copy link
Copy Markdown
Member

I'm fine with that, very happy for dask-native reproject!

@Cadair Cadair left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't given this a super detailed review but it looks good to me.

Comment thread reproject/array_utils.py

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 the horror.

@astrofrog astrofrog merged commit e54cd7c into astropy:main Nov 13, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants