pre-commit.ci autofix

Codecov Report

❌ Patch coverage is 79.41176% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.86%. Comparing base (27aee71) to head (ce6538c).
⚠️ Report is 123 commits behind head on main.

@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
- Coverage   91.45%   88.86%   -2.59%     
==========================================
  Files          25       28       +3     
  Lines        1088     1374     +286     
==========================================
+ Hits          995     1221     +226     
- Misses         93      153      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The current approach doesn't produce the index.html file:

reproject_to_hips('/Users/adam/work/gc/ACES/ACES_tour_Aladin/12m_continuum_commonbeam_circular_reimaged_mosaic_MUSTANGfeathered_zerod.fits', coord_system_out='galactic', level=4, reproject_function=reproject_interp, output_directory='REPROJECT_TO_HIPS_MUSTANG_EXPERIMENT', progress_bar=tqdm)

$ ls REPROJECT_TO_HIPS_MUSTANG_EXPERIMENT
Norder0/    Norder1/    Norder2/    Norder3/    Norder4/    properties

@keflavich - I've pushed some new changes. This now supports reprojecting from PNG/JPG with AVM. Here is an example:

import os
import shutil

from tqdm.notebook import tqdm
from reproject.hips import reproject_to_hips
from reproject import reproject_interp

filename = "MUSTANG_12m_feather_noaxes.png"
output_directory = filename.replace('.png', '_hips')

if os.path.exists(output_directory):
    shutil.rmtree(output_directory)

reproject_to_hips(filename,
              coord_system_out='galactic',
              level=6,
              reproject_function=reproject_interp,
              output_directory=output_directory,
              progress_bar=tqdm)

This now also outputs an index.html file, so if I serve the output directory and open it in the browser, I get:

Ok I've now added a new coadd_hips function which can be add to combine multiple HiPS maps in the same coordinate frame (but potentially different order) into a single HiPS dataset:

from reproject.hips import coadd_hips
coadd_hips(['MUSTANG_12m_feather_noaxes_hips', 'MUSTANG_12m_feather_noaxes_offset_hips'], 'test_coadd')

Currently if there is overlap, the last image is shown on top. We could have some more fancy blending in future.

I'm not sure the coordinate_system_output is working; your example screenshot and my local reproduction both put it in celestial coordinates, not galactic

I have an example RGBA file. Can we handle those? They have a 4th layer. Does Aladin support transparency?

coadd didn't work:

from reproject.hips import coadd_hips
coadd_hips(['rgb_final_uncropped_hips', 'MUSTANG_12m_feather_noaxes_hips'], 'AshFigureWithACES')

Traceback (most recent call last):
  File ~/repos/avm_images/python_reproject_to_hips.py:58
    coadd_hips(['rgb_final_uncropped_hips', 'MUSTANG_12m_feather_noaxes_hips'], 'AshFigureWithACES')
  File ~/repos/python-reprojection/reproject/hips/core.py:360 in coadd_hips
    raise NotImplementedError()
NotImplementedError

most likely because one of these is jpeg and the other png

with pngs:

Traceback (most recent call last):
  File ~/repos/avm_images/python_reproject_to_hips.py:66
    coadd_hips(['rgb_final_uncropped_hips', 'MUSTANG_12m_feather_noaxes_hips'], 'AshFigureWithACES')
  File ~/repos/python-reprojection/reproject/hips/core.py:327 in coadd_hips
    raise ValueError("tile_format values do not match: {tile_formats}")
ValueError: tile_format values do not match: {tile_formats}

...I think there's a formatting error there that I'll fix...

ok yeah, this error message is more useful, but strangely incorrect now...

Traceback (most recent call last):
  File ~/repos/avm_images/python_reproject_to_hips.py:66
    coadd_hips(['rgb_final_uncropped_hips', 'MUSTANG_12m_feather_noaxes_hips'], 'AshFigureWithACES')
  File ~/repos/python-reprojection/reproject/hips/core.py:327 in coadd_hips
    raise ValueError(f"tile_format values do not match: {tile_formats}")
ValueError: tile_format values do not match: ['png', 'jpeg']

ok, forced both things into .png format, and unfortunately I only get one image

Currently if there is overlap, the last image is shown on top. We could have some more fancy blending in future.

No, the first image is shown on top. 🤷

the tqdm progressbar doesn't work, it always reports 0%

we have some successes, e.g.: https://keflavich.github.io/avm_images/AshFigureWithACES_MUSTANGfirst/index.html

looking at some of the index.html's generated by aladin.jar, getting the image to be oriented in galactic (not just projected into galactic, but also shown that way) requires non-negligible javascript in the index

the tqdm progressbar doesn't work, it always reports 0%

user error; I copied the code snippet above but I wasn't in a notebook

As this PR has got quite large and at least works I am going to go ahead and merge this PR and open up follow-up issues/PRs for the various unresolved items.