Added sp-repo-review to pre-commit by astrofrog · Pull Request #411 · astropy/reproject · GitHub
Skip to content

Added sp-repo-review to pre-commit#411

Merged
astrofrog merged 15 commits into
astropy:mainfrom
astrofrog:sp-repo-review
Dec 8, 2023
Merged

Added sp-repo-review to pre-commit#411
astrofrog merged 15 commits into
astropy:mainfrom
astrofrog:sp-repo-review

Conversation

@astrofrog

@astrofrog astrofrog commented Nov 17, 2023

Copy link
Copy Markdown
Member

Just exploring sp-repo-review and seeing if it provides useful feedback

Fixes #421

@codecov

codecov Bot commented Nov 17, 2023

Copy link
Copy Markdown

@astrofrog

Copy link
Copy Markdown
Member Author

Note to self: I need to update the path to the coverage config file in tox.ini

@astrofrog astrofrog marked this pull request as ready for review November 28, 2023 19:26
@astrofrog

Copy link
Copy Markdown
Member Author

@neutrinoceros neutrinoceros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have nothing of value to add here !

@astrofrog astrofrog merged commit 14825b9 into astropy:main Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BLD: build is currently broken on Python 3.8

2 participants