Phase 3 funding | Aperio | GUI-editable regions by keflavich · Pull Request #272 · astropy/astropy-project · GitHub
Skip to content

Phase 3 funding | Aperio | GUI-editable regions - #272

Merged
kelle merged 7 commits into
astropy:mainfrom
keflavich:patch-3
Oct 24, 2022
Merged

kelle merged 7 commits into
astropy:mainfrom
keflavich:patch-3

Conversation

@keflavich

Copy link
Copy Markdown
Contributor

Proposal to finish the work on making regions GUI-editable.

@keflavich
keflavich marked this pull request as draft July 8, 2022 07:08
@keflavich

Copy link
Copy Markdown
Contributor Author

@dhomeier

dhomeier commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

@dhomeier I'd like your direct input on this - could you help assess what an appropriate level of effort is?

I think so far we have spent some 150 hours mainly on the regions side, which is now primarily waiting on a finalised matplotlib API. But all the more important to have the hours to adapt the regions PRs to that once finished.
@dstansby may have a better overview how much work is yet to do in matplotlib.widgets.

Scope of the documentation part is probably fairly open.

@dstansby

dstansby commented Jul 8, 2022

Copy link
Copy Markdown

@keflavich can you remove me from this? I haven't been asked or agreed to be part of a proposal.

The remaining work in matplotlib.widgets is to rebase the PRs linked in the documentation, and then have two Matplotlib developers to review/accept the work. The blocker when I did this work previously was disagreement on the MPL side on how rectangles should be rotated, but this is now resolved: matplotlib/matplotlib#21945 (comment)

@dhomeier

dhomeier commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

The blocker when I did this work previously was disagreement on the MPL side on how rectangles should be rotated, but this is now resolved: matplotlib/matplotlib#21945 (comment)

It was not clear to me from that comment if changing the implementation to "stay a rectangle in display coordinates" was mostly or largely done, or needed substantial coding yet. If the former, the work should hopefully be on a comparable level to what is needed in regions itself.

@dstansby

dstansby commented Jul 8, 2022

Copy link
Copy Markdown

From memory (deinitely needs checking to verify) matplotlib/matplotlib#21945 contains all of the implementation for keeping the rectangles rectangles in display coordinates.

@jdswinbank

Copy link
Copy Markdown
Contributor

Because the estimated total of all the proposals is a bit higher than the amount available for allocation, we suggest that you (@keflavich ) provide a budget range - i.e., a "minimum for this project to be viable" and "maximum you could use effectively for this project".

@dhomeier

Copy link
Copy Markdown
Contributor

Depending on the level of familiarity with the present matplotlib implementation I suppose the 50 h minimum should probably allow adapting that and the existing regions PRs, without any further documentation.

@keflavich
keflavich marked this pull request as ready for review August 18, 2022 16:10
@pllim

pllim commented Aug 18, 2022

Copy link
Copy Markdown
Member

FWIW, Jdaviz has a plugin to edit region shapes already (caveat: limited shapes support, needs to go through glue).

https://jdaviz.readthedocs.io/en/latest/imviz/plugins.html#subset-tools

@pllim

pllim commented Aug 18, 2022

Copy link
Copy Markdown
Member

Ginga also has shape edit capability (caveat: starts out as Ginga shape object but it has translator for regions).

https://ginga.readthedocs.io/en/latest/manual/plugins_local/drawing.html

https://ginga.readthedocs.io/en/latest/dev_manual/canvas.html#support-for-astropy-regions

Comment thread finance/proposal-calls/cycle3/editable-regions.md Outdated
Comment thread finance/proposal-calls/cycle3/editable-regions.md Outdated
Comment thread finance/proposal-calls/cycle3/editable-regions.md Outdated
keflavich and others added 3 commits August 19, 2022 07:41
Co-authored-by: Thomas Robitaille <thomas.robitaille@gmail.com>
Co-authored-by: Thomas Robitaille <thomas.robitaille@gmail.com>
Co-authored-by: Thomas Robitaille <thomas.robitaille@gmail.com>
@kelle

kelle commented Aug 22, 2022

Copy link
Copy Markdown
Member

Please react to this comment to vote on this proposal (👍, 👎, or no reaction for +0).

@jdswinbank

Copy link
Copy Markdown
Contributor

@kelle
kelle merged commit d12a877 into astropy:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants