{{ message }}
Allow more tests to run without latest IERS data - #17377
Merged
Merged
Conversation
In 382bb84 (Mark some "future" test in coordinates as remote_data) a few tests were marked as remote data tests because they tried to fetch IERS data over the Internet if the bundled data was too old. However, that change disables the tests in question entirely in normal test runs. By applying a temporary configuration change, it is possible to only prevent Internet access while still allowing the tests to run.
Contributor
pllim
approved these changes
Nov 11, 2024
pllim
left a comment
pllim
left a comment
Member
There was a problem hiding this comment.
LGTM thanks! But I'll give others a chance to review as well. Might as well backport.
neutrinoceros
approved these changes
Nov 12, 2024
neutrinoceros
left a comment
neutrinoceros
left a comment
Contributor
There was a problem hiding this comment.
Thanks for those clear reviewing guidelines !
neutrinoceros
enabled auto-merge
November 12, 2024 08:58
Contributor
pllim
disabled auto-merge
November 12, 2024 14:48
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Nov 12, 2024
pllim
added a commit
that referenced
this pull request
Nov 12, 2024
…377-on-v7.0.x Backport PR #17377 on branch v7.0.x (Allow more tests to run without latest IERS data)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #17359 a few tests were marked as remote data tests because they tried to fetch IERS data over the Internet if the bundled data was too old. However, that change disables the tests in question entirely in normal test runs. The allowed age of the IERS data is configurable and the
astropyconfiguration system has simple ways of modifying the configuration temporarily only for some block of code. It is therefore very simple to allow the tests to run even without Internet access.To verify that the patch here works you must have an older version of
astropy-iers-datainstalled so that the tests fail with some commit that predates #17359 (e.g. 59f1ada). You can then see that 382bb84 does indeed prevent test failures, but at the cost of skipping the tests entirely, and that this patch allows the tests to run successfully.