{{ message }}
Adding MissingConstraintWarning warning#528
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was originally meant to address #514 from @knservis, but it widened into a few overdue improvements.
New features:
– A
MissingConstraintWarningis raised when the user runsmonths_observable(constraints, ...)without anAltitudeConstraintor anAirmassConstraintamong the constraints.Improvements
– better handling of
nantimes within astroplan– old manifest contents for astropy helpers are removed
– a hidden method
_process_nans_in_jdshandles the masking of "bad" times uniformly across methods within theObserverclassCloses #514