{{ message }}
WIP: fix #317: allow editing the message once it gets available in the db …#583
Open
gauteh wants to merge 1 commit into
Open
WIP: fix #317: allow editing the message once it gets available in the db …#583gauteh wants to merge 1 commit into
gauteh wants to merge 1 commit into
Conversation
… in the db after sending
gauteh
changed the title
Contributor
|
Is there anything preventing these changes from being merged? Do you need more bug testing? EDIT: I have just downloaded and built this branch, but I don't see any difference in behaviour. I cannot tag in the new message window, I have to save a draft, tag that draft and then send it. |
Member
Author
|
I think there was a crash that needed fixing.
ons. 24. apr. 2019 kl. 11:11 skrev Hugh Williams <notifications@github.com>:
… Is there anything preventing these changes from being merged? Do you need
more bug testing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#583 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAN367SVFCEESGJYV3MIULPSAP4PANCNFSM4F6J6X3A>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…after sending
Fixes #317.
Since a full thread object isn't set up for the ThreadView there might be some ways to break this, please try. Also, hopefully all functionality which should be off after sending is now off.. (in particular deleting attachments seem to maybe be possible?)
@mxmehl Please take a look.
TODO:
Related #581