{{ message }}
Disable tests failing on Windows#3185
Closed
Bananeweizen wants to merge 1 commit into
Closed
Conversation
* The conversion shell scripts cannot be executed on Windows. * Path related tests trying to create symbolic links fail with an exception on Windows, as documented in java.nio.file.Files.createSymbolicLink(Path, Path, FileAttribute<?>...)
scordio
added
the
status: pending investigation
scordio
force-pushed
the
3.x
branch
2 times, most recently
from
301ca01 to
c730d18
Compare
3 tasks
Member
Member
I refactored how we do script testing in #3785: this is now a separate Maven module running on non-Windows platforms only, and using JUnit Although my PR has taken a different direction from this one, I truly appreciated that you looked into the problem, somehow hidden before, therefore I'm adding you as a coauthor 😉 |
scordio
removed
the
status: pending investigation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
java.nio.file.Files.createSymbolicLink(Path, Path, FileAttribute<?>...)
Check List:
With this change I can build the complete Maven reactor. Without it, there are around 50 test failures, exactly on the disabled test classes and methods.