{{ message }}
Fixed N and D comment for KMeans example#3584
Merged
christophe-murphy merged 1 commit intoarrayfire:masterfrom Oct 1, 2024
Merged
Fixed N and D comment for KMeans example#3584christophe-murphy merged 1 commit intoarrayfire:masterfrom
christophe-murphy merged 1 commit intoarrayfire:masterfrom
Conversation
christophe-murphy
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The machine_learning/kmeans.cpp example has a comment which says n is the number of features and d is the feature size (the code is correct, but the comment explaining it mixes up the values).
It may not seem like a big deal, but I found this example when working on my own project with different dimensions, and it caused me a headache debugging why my dimensions were wrong when using your example since I had flipped N and D.
Checklist