More fast math by umar456 · Pull Request #3337 · arrayfire/arrayfire · GitHub
Skip to content

More fast math#3337

Merged
umar456 merged 2 commits intoarrayfire:masterfrom
umar456:more_fast_math
Nov 26, 2022
Merged

More fast math#3337
umar456 merged 2 commits intoarrayfire:masterfrom
umar456:more_fast_math

Conversation

@umar456
Copy link
Copy Markdown
Member

@umar456 umar456 commented Nov 25, 2022

Fix tests and improve the AF_WITH_FAST_MATH option in OpenCL and CUDA

Description

  • Pass fast math flag to nvcc
  • Pass fast math flag to nvrtc
  • Pass fast math flag to OpenCL
  • Fix min and max function when AF_WITH_FAST_MATH is set because infinity doesn't exist with fast math
  • Set cuBLAS math mode to CUBLAS_TF32_TENSOR_OP_MATH when AF_WITH_FAST_MATH is set

Changes to Users

N/A

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

Copy link
Copy Markdown
Member

@9prady9 9prady9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have any fast mode specific tests ?

@umar456
Copy link
Copy Markdown
Member Author

umar456 commented Nov 26, 2022

@umar456 umar456 merged commit 2181739 into arrayfire:master Nov 26, 2022
@umar456 umar456 deleted the more_fast_math branch November 26, 2022 18:23
@WilliamTambellini
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants