{{ message }}
Add trace for kernel launches#3143
Merged
umar456 merged 2 commits intoarrayfire:masterfrom Jun 22, 2021
Merged
Conversation
9prady9
reviewed
Jun 9, 2021
Member
9prady9
left a comment
9prady9
left a comment
There was a problem hiding this comment.
looks good.
although i dislike std::string usage after i became aware of the issues it can potentially cause. we already kind of use it in many locations though.
Member
There was a problem hiding this comment.
this is added in common interface target, dont we use common interface target with this static lib ?
. also it will fail when we looj for system/vcpkg provided spdlog target spdlog::spdlog_header_only -- perhaps I can handle this in my PR #3139
9prady9
approved these changes
Jun 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add traces for kernel launches for OpenCL and CUDA. This will print kernel names for CUDA and OpenCL. It will print the launch configuration(blocks, threads) for CUDA
Description
[kernel][1623190555][731273] [ /data/devel/arrayfire/src/backend/cuda/kernel/random_engine.hpp:1064 ] Launching uniformPhilox: Blocks: [1] Threads: [256] Shared Memory: 0[kernel][1623193966][746791] [ ../src/backend/opencl/Kernel.hpp:33 ] Launching philoxGeneratorChanges to Users
Users can filter these traces by setting the environment variable AF_TRACE to
kernelChecklist
[ ] Functions added to unified API[ ] Functions documented