{{ message }}
Fix empty array handling in lu, rank, and qr. Other minor refactoring#2838
Merged
umar456 merged 4 commits intoarrayfire:masterfrom Apr 13, 2020
Merged
Fix empty array handling in lu, rank, and qr. Other minor refactoring#2838umar456 merged 4 commits intoarrayfire:masterfrom
umar456 merged 4 commits intoarrayfire:masterfrom
Conversation
Member
umar456
commented
Apr 11, 2020
umar456
commented
- some linear algebra functions could have leaked memory in case the input was null. This PR addresses that potential leak and handles the empty or null array case.
- Minor refactor in median
- Minor refactor in DefaultMemoryManager. Just changed names of the variables.
9prady9
requested changes
Apr 11, 2020
Member
9prady9
left a comment
9prady9
left a comment
There was a problem hiding this comment.
Please also fix the formatting problem in the following files:
test/memory.cpp
test/median.cpp
9prady9
requested changes
Apr 13, 2020
Member
9prady9
left a comment
9prady9
left a comment
There was a problem hiding this comment.
Memory leaks in all new tests for lu_dense.cpp, qr_dense.cpp and rank_dense.cpp. I believe that is why the ASAN tests failed.
Also, the formatting is still off in test/memory.cpp file.
Member
Author
9prady9
approved these changes
Apr 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.