{{ message }}
fix(skills): accept policy.products in plugin-creator skill validation - #3
Open
argszero wants to merge 1 commit into
Open
fix(skills): accept policy.products in plugin-creator skill validation#3argszero wants to merge 1 commit into
argszero wants to merge 1 commit into
Conversation
The bundled plugin-creator validator rejected `policy.products` in a skill's `agents/openai.yaml` as an unsupported field, even though the skill metadata model (ext/skills Policy.products: Vec<Product>) supports product-specific invocation restrictions. Allow `products` on the skill-agent policy block and validate it is an array of non-empty strings, continuing to reject malformed values. Fixes openai#42570.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bundled plugin-creator validator rejected
policy.productsin a skill'sagents/openai.yamlas an unsupported field, even though the skill metadata model (ext/skillsPolicy.products: Vec<Product>) supports product-specific invocation restrictions.This change allows
productson the skill-agent policy block and validates it is an array of non-empty strings, continuing to reject malformed values.Related Issue
Closes openai#42570
Tests
python3 -B -m unittest discover -s codex-rs/skills/tests -p 'test_*.py')policy.productsand malformed (non-list / non-string) values