{{ message }}
Skip null export targets during entrypoint discovery#272
Merged
andrewbranch merged 1 commit intoJun 22, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes core entrypoint discovery so that package.json#exports subpaths whose resolved target is explicitly null are treated as blocked (per Node’s exports semantics) and are not considered real package entrypoints. This prevents the CLI/core analysis from checking and reporting “broken” entrypoints that are intentionally excluded via null.
Changes:
- Update entrypoint discovery to ignore export subpaths whose target tree contains no real (non-null) export target.
- Add a regression test covering
nulltargets for subpath patterns and conditional exports. - Add a changeset to release the fix as a patch for
@arethetypeswrong/core.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core entrypoint discovery was treating
exportssubpaths withnulltargets as real package entrypoints.This skips blocked targets while still keeping arrays, conditions, and nested objects when at least one branch points to a real target. I added regression coverage and checked it with the core tests passing 56/56,
pnpm tsgo,pnpm check-dts, Prettier, build, andgit diff --check.Fixes #242