Make `requestParams` required if any param is required, otherwise keep it optional by ardatan · Pull Request #309 · ardatan/feTS · GitHub
Skip to content

Make requestParams required if any param is required, otherwise keep it optional - #309

Merged
ardatan merged 2 commits into
masterfrom
request-params-required
Jul 11, 2023
Merged

ardatan merged 2 commits into
masterfrom
request-params-required

Conversation

@ardatan

@ardatan ardatan commented Jul 11, 2023

Copy link
Copy Markdown
Owner

Before requestParams argument of any client method was optional, now it is required if any param is required otherwise it is still optional.

@github-actions

github-actions Bot commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

💻 Website Preview

The latest changes are available as preview in: https://37ac51a6.fets.pages.dev

@github-actions

github-actions Bot commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

@ardatan
ardatan merged commit 663d2e0 into master Jul 11, 2023
@ardatan
ardatan deleted the request-params-required branch July 11, 2023 14:17
@theguild-bot theguild-bot mentioned this pull request Oct 26, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant