Async Support in Python SDK by ms7m · Pull Request #453 · appwrite/sdk-generator · GitHub
Skip to content

Async Support in Python SDK - #453

Closed
ms7m wants to merge 17 commits into
appwrite:masterfrom
ms7m:master
Closed

Async Support in Python SDK#453
ms7m wants to merge 17 commits into
appwrite:masterfrom
ms7m:master

Conversation

@ms7m

@ms7m ms7m commented May 24, 2022

Copy link
Copy Markdown

More information @ #452

@ms7m ms7m mentioned this pull request May 24, 2022
Closed
2 tasks done
@TorstenDittmann

TorstenDittmann commented Jun 1, 2022

Copy link
Copy Markdown
Contributor

@TorstenDittmann
TorstenDittmann requested a review from abnegate June 1, 2022 14:51
abnegate
abnegate requested changes Jun 8, 2022
View reviewed changes

@abnegate abnegate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far! Just a few comments

Comment thread .travis.yml Outdated
Comment thread templates/python/package/aio/exception.py.twig Outdated
Comment thread templates/python/package/aio/input_file.py.twig Outdated
Comment thread templates/python/package/aio/query.py.twig Outdated
Comment thread templates/python/package/aio/service.py.twig Outdated
Comment thread templates/python/package/aio/client.py.twig Outdated
Comment thread templates/python/package/aio/services/service.py.twig
@ms7m

ms7m commented Jun 15, 2022

Copy link
Copy Markdown
Author

Nice work so far! Just a few comments

Thanks, I've been swamped at work and battling a cold -- but I'll get these changes sorted!

@ms7m
ms7m requested a review from abnegate June 18, 2022 03:44
@stnguyen90

stnguyen90 commented Oct 14, 2022

Copy link
Copy Markdown
Contributor

@ms7m, sorry, but would you please fix the merge conflict?

@ms7m

ms7m commented Oct 15, 2022

Copy link
Copy Markdown
Author

@stnguyen90 sure, my branch is quite behind since this kinda fell off my radar.

@stnguyen90
stnguyen90 requested review from stnguyen90 and removed request for abnegate December 27, 2022 17:21
stnguyen90
stnguyen90 suggested changes Dec 27, 2022
View reviewed changes

@stnguyen90 stnguyen90 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ms7m it seems like the tests are failing.

@lohanidamodar

lohanidamodar commented Jan 29, 2023

Copy link
Copy Markdown
Member

@abnegate is this relevant?

@stnguyen90

stnguyen90 commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

@ms7m seems like the tests are still failing. Any ideas why?

@ms7m

ms7m commented Feb 8, 2023

Copy link
Copy Markdown
Author

@stnguyen90 -- running locally, only a single test is failing. I'll take a crack at this weekend and get this freed up!

@abnegate

abnegate commented Feb 14, 2023

Copy link
Copy Markdown
Member

@ms7m Is it possible to have the async methods without adding the AsyncClient? So the async versions of the methods would be together with the sync versions in the existing client?

@stnguyen90 stnguyen90 mentioned this pull request Apr 28, 2023
Open
@stnguyen90 stnguyen90 linked an issue Apr 28, 2023 that may be closed by this pull request
Idea: Make SDK asynchronous. appwrite/sdk-for-python#26
Open
@iron3oxide

iron3oxide commented May 27, 2024

Copy link
Copy Markdown

It's been a while since the last update here and I'd love to see this feature implemented. @ms7m are you still working on it? If not, I might take a crack at it myself

@s4093120

s4093120 commented Dec 5, 2024

Copy link
Copy Markdown

@bhardwajparth51 bhardwajparth51 mentioned this pull request Apr 16, 2026
Open
2 tasks done
@ChiragAgg5k
ChiragAgg5k deleted the branch appwrite:master June 11, 2026 07:41
@bhardwajparth51 bhardwajparth51 mentioned this pull request Jul 25, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abnegate abnegate abnegate requested changes
+1 more reviewer
@stnguyen90 stnguyen90 stnguyen90 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Idea: Make SDK asynchronous.

8 participants

@ms7m @TorstenDittmann @stnguyen90 @lohanidamodar @abnegate @iron3oxide @s4093120 @ChiragAgg5k