{{ message }}
Repository navigation
feat: Python SDK update for version 25.0.0 - #159
Closed
ChiragAgg5k wants to merge 2 commits into
Closed
ChiragAgg5k wants to merge 2 commits into
ChiragAgg5k wants to merge 2 commits into
Conversation
![hansi-codes[bot]](https://avatars.githubusercontent.com/in/5046327?s=60&v=4){kind=small}
| if 'migrationId' not in data and 'migrationid' not in data: | ||
| data['migrationId'] = '' | ||
| if 'options' not in data: | ||
| data['options'] = [] |
There was a problem hiding this comment.
Use mapping defaults for dict-valued fields
When options is missing, this validator inserts [] even though the field is now Dict[str, Any], so Pydantic raises a validation error instead of filling the missing field. The same list default is used for dict-valued fields such as Message.data, Provider.credentials, Project.onboarding, PasskeyChallenge.publicKey, InsightCTA.params, and WAF rule config.
Prompt To Fix With AI
This is a comment left during a code review.
Path: appwrite/models/backup_restoration.py
Line: 71
Comment:
**Use mapping defaults for dict-valued fields**
When `options` is missing, this validator inserts `[]` even though the field is now `Dict[str, Any]`, so Pydantic raises a validation error instead of filling the missing field. The same list default is used for dict-valued fields such as `Message.data`, `Provider.credentials`, `Project.onboarding`, `PasskeyChallenge.publicKey`, `InsightCTA.params`, and WAF rule `config`.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · bug · Reply if this doesn't apply.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains updates to the Python SDK for version 25.0.0.