{{ message }}
Repository navigation
fix: SDK update for version 29.3.1 - #175
Merged
Merged
Conversation
![hansi-codes[bot]](https://avatars.githubusercontent.com/in/5046327?s=60&v=4){kind=small}
Comment on lines
+1943
to
+1944
There was a problem hiding this comment.
Test still exercises password-dictionary, not passkey
This fixture has passkey fields, but the test still calls getPolicy('password-dictionary') and its $id remains password-dictionary. It will pass without ever exercising a passkey lookup, so it does not verify the newly added policy path.
Prompt To Fix With AI
This is a comment left during a code review.
Path: test/services/project.test.js
Line: 1943-1944
Comment:
**Test still exercises password-dictionary, not passkey**
This fixture has passkey fields, but the test still calls `getPolicy('password-dictionary')` and its `$id` remains `password-dictionary`. It will pass without ever exercising a passkey lookup, so it does not verify the newly added policy path.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · testing · Reply if this doesn't apply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains updates to the SDK for version 29.3.1.
What's Changed
ProjectAuthMethodId.Passkey, soproject.updateAuthMethodcan enable passkeysProjectPolicyId.Passkeyand theModels.PolicyPasskeymodel, sogetPolicyandlistPoliciesreturn the passkey policyCompletes the passkeys release: 29.3.0 shipped the passkey methods, but not the
passkeyauth method and policy IDs or thePolicyPasskeymodel, so the SDK could not enable passkeys on a project. Made from a spec with exactly these pieces removed, three-way merged onto29.x. Build and all 903 jest tests pass.