{{ message }}
Repository navigation
Add dynamic API keys for function executions - #7512
Merged
Merged
Conversation
eldadfux
requested changes
Jan 30, 2024
eldadfux
added
product / functions
eldadfux
reviewed
May 7, 2024
eldadfux
reviewed
May 17, 2024
eldadfux
approved these changes
May 17, 2024
Comment on lines
+286
to
+291
Contributor
There was a problem hiding this comment.
Shouldn't we save this API key to the db as well? How do we validate this key?
Contributor
Author
There was a problem hiding this comment.
We decode JWT to get projectId and scopes. We then set those on the Auth of the request.
christyjacob4
approved these changes
May 24, 2024
stnguyen90
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces API Tokens to function executions. They are automatically provided short-liked JWT tokens that developer can use instead of creating and maintaining API keys for their functions.
Test Plan
Related PRs and Issues
x
Checklist