{{ message }}
Repository navigation
Add _APP_CONSOLE_HOSTNAMES env var to allow more hostnames to the console project - #7377
Merged
TorstenDittmann merged 2 commits intoJan 3, 2024
Conversation
stnguyen90
changed the title
_APP_CONSOLE_HOSTNAMES env var to allow more hostnames to the console project
TorstenDittmann
approved these changes
Jan 3, 2024
TorstenDittmann
deleted the
feat-console-hostnames-on-refactor-usage-sn
branch
January 3, 2024 16:24
stnguyen90
commented
Jan 3, 2024
Comment on lines
+930
to
+931
Contributor
Author
There was a problem hiding this comment.
Hmm if App::getEnv('_APP_CONSOLE_HOSTNAMES', '') and an empty string, $hostnames will be an array with 1 empty string.
That shouldn't be added as a platform, right?
Contributor
There was a problem hiding this comment.
ohhh, one of those weird PHP things. We should fix it before releasing.
This was referenced Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
_APP_CONSOLE_HOSTNAMESenvironment variable to allow more hostnames to the console projectTest Plan
Related PRs and Issues
Checklist