{{ message }}
Repository navigation
Update README.md - #248
Merged
Merged
Update README.md#248
Conversation
Added the license details (and linked to the license page) in the README file.
Added a blank line after a heading and replaced the absolute path with a relative path.
2 tasks
pull Bot
pushed a commit
to AmirulAndalib/appwrite
that referenced
this pull request
Sep 22, 2026
…retry-dead-pooled-connection fix(telemetry): retry an export once when the pooled connection is reset mid-request
pull Bot
pushed a commit
to AmirulAndalib/appwrite
that referenced
this pull request
Sep 28, 2026
…ppwrite#248) * Chore: Upgrade PHPUnit to 12, modernize tests, refresh Rector sets - Bump phpunit/phpunit ^9.5 -> ^12.0, phpstan/phpstan ^2.0 -> ^2.1, rector/rector ^2.0 -> ^2.4. - Migrate phpunit.xml to the PHPUnit 12 schema; exclude the BaseTest trait and the misnamed UtopiaFPMRequestTest mock helper from the unit suite. - Add PHPUnit 10/11/12, code-quality, and annotations-to-attributes sets to rector.php; drop three skip entries rector reported as unregistered; skip AssertEmptyNullableObjectToAssertInstanceofRector since it weakens assertNull. - Apply rector: declare(strict_types=1) in tests, final test classes, generator data provider, and assertEquals -> assertSame where types are inferable. - Manual cleanup: assertEquals(null|true|false, x) -> specific methods; fix RequestTest::testCanRemoveHeaders which relied on null == '' loose equality (getHeader returns string); replace closure-vs-closure assertEquals in RouteTest::testCanSetAndGetAction with assertInstanceOf(Closure::class, ...). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Chore: Bump swoole test image to appwrite/base:1.2.0 (PHP 8.5) The CI e2e-swoole job failed because appwrite/base:0.5.0 ships PHP 8.2.6, but PHPUnit 12 requires PHP >= 8.3. Bumping to 1.2.0 (PHP 8.5.4, swoole included) matches the library's >=8.3 floor and the host test runtime. Drop the now-redundant curl_close() call in tests/e2e/Client.php — PHP 8.5 deprecates it (the handle is released on last reference since 8.0 anyway). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Chore: Declare coverage source in phpunit.xml PHPUnit 12 requires a <source> section for coverage to run; without it the runner emits "No filter is configured, code coverage will not be processed" and CI's --coverage-* flags exit non-zero. Point coverage at ./src. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Chore: Add PHPUnit schema reference, tighten Route/Response assertions - phpunit.xml: add xmlns:xsi and xsi:noNamespaceSchemaLocation pointing at vendor/phpunit/phpunit/phpunit.xsd so PHPUnit 12 (and IDE tooling) get XML schema validation. - HttpTest: swap reversed assertEquals(actual, expected) pairs in testCanSetRoute, testCanMatchRoute, and testCanMatchFreshRoute to the expected-first convention, and promote them to assertSame — setRoute and match return the exact Route instance, so identity is the precise check and the diff on failure reads correctly. - ResponseTest: promote fluent-interface assertions on addHeader / addCookie to assertSame for the same reason. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added the license details (and linked to the license page) in the README file.