Fix installer secret handling and benchmark Markdown escaping by Tapraj-Pathak · Pull Request #14699 · appwrite/appwrite · GitHub
Skip to content

Fix installer secret handling and benchmark Markdown escaping - #14699

Open
Tapraj-Pathak wants to merge 5 commits into
appwrite:mainfrom
Tapraj-Pathak:fix-installer-secret-and-benchmark-escaping
Open

Tapraj-Pathak wants to merge 5 commits into
appwrite:mainfrom
Tapraj-Pathak:fix-installer-secret-and-benchmark-escaping

Conversation

@Tapraj-Pathak

Copy link
Copy Markdown

Summary

  • Exchange the installer URL capability for a random HttpOnly, SameSite=Strict session cookie scoped to /install, with a 24-hour expiry and cleanup when installation completes.
  • Remove legacy browser-side installer-secret storage and protect the capability exchange redirect with no-store and no-referrer headers.
  • Escape backslashes before Markdown table pipes in benchmark report cells.
  • Add installer E2E coverage and a dedicated CI lane.

Related: #14675

Validation

  • PHP syntax checks, installer session-state smoke test, benchmark Markdown escaping check, CI config validation, and git diff --check passed.
  • Installer E2E and Pint could not be run in the workspace because Composer dependencies, PHPUnit, and Swoole are unavailable.

Exchange the installer URL capability for an expiring HttpOnly session cookie, and escape backslashes before Markdown table pipes. Add installer E2E coverage and CI lane.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hansi-codes

hansi-codes Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · See the inline comments. Summary

Comment thread tests/e2e/Services/Installer/InstallerSessionTest.php Outdated
Comment thread phpunit.xml Outdated
Tapraj-Pathak and others added 2 commits October 20, 2026 09:17
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…rk-escaping' into fix-installer-secret-and-benchmark-escaping

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant