{{ message }}
Repository navigation
Conversation
Contributor
🟢 Tier S · Ready to mergeThe bulk-operations benchmark assertion helper no longer logs HTTP response bodies when an assertion fails. It continues to report the assertion name and response status, then throws the assertion error.
📂 Walkthrough · 1
Reviewed |
![hansi-codes[bot]](https://avatars.githubusercontent.com/in/5046327?s=60&v=4){kind=small}
Security rulesNo new WARNING or ERROR findings from security rules. 19 existing findings tracked in
|
![tenki-reviewer[bot]](https://avatars.githubusercontent.com/in/2900641?s=60&v=4){kind=small}
✨ Benchmark resultsComparing
Per-scenario breakdown & investigation detailsMetrics below reflect the current branch (after). Δ P95 compares against the base.
Top API waits (after) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed benchmark setup calls currently print the complete HTTP response body, which can expose API keys or session data in logs (CodeQL #511). Remove that body log and retain the assertion name, HTTP status, and thrown error.
Validation: exercised the actual assertion function with a failing response containing a sentinel secret. The original code logs it; the changed code keeps the status and failure while omitting the body. JavaScript syntax check and git diff --check pass.
Related triage: #14675. The neighboring status-only alert #510 is a false positive and is dismissed separately. Full benchmark E2E was not run; this changes only failure logging.