{{ message }}
Repository navigation
fix(init): make the PHP memory limit configurable - #14522
Open
HarshMN2345 wants to merge 3 commits into
Open
HarshMN2345 wants to merge 3 commits into
HarshMN2345 wants to merge 3 commits into
Conversation
Signed-off-by: Jyotirmoy Roy <jyotirmoyroy649@gmail.com>
…mory-limit fix: make the PHP memory limit configurable via _APP_MEMORY_LIMIT
Set its introduction to the next patch, since 2.4.0 has shipped, and shorten the description.
Contributor
🟢 Tier S · Ready to merge
The PHP bootstrap now reads its memory limit from
📂 Walkthrough · 4
Reviewed |
![hansi-codes[bot]](https://avatars.githubusercontent.com/in/5046327?s=60&v=4){kind=small}
![tenki-reviewer[bot]](https://avatars.githubusercontent.com/in/2900641?s=60&v=4){kind=small}
✨ Benchmark resultsComparing
Per-scenario breakdown & investigation detailsMetrics below reflect the current branch (after). Δ P95 compares against the base.
Top API waits (after)
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app/init.phphardcodedini_set('memory_limit', '512M')for every process, overridingphp -dand ini files, so a Realtime worker died at 512 MB and dropped every connection on that node.The limit now reads
_APP_MEMORY_LIMIT, still defaulting to512M. It's forwarded to every PHP service indocker-compose.yml(the threeextendsservices inherit it), defined invariables.phpnext to_APP_WORKER_PER_COREwith introduction2.5.1, and added to.env.Tested: loaded the real
app/init.phpinappwrite-dev:latestunderphp -d memory_limit=128M. With_APP_MEMORY_LIMITunset or empty the limit is512M; with2Git's2G; with-1it's-1.pint --testpasses on both PHP files.Closes #14437
Related: #14454 (merged into this branch), #13162 (same change, open since August)