iframe-proxy

ChiragAgg5k · 2026-09-22T19:08:38Z

Summary

Move utopia-php/pools into packages/pools so Appwrite loads it directly, step 3 of the messaging chain in #13828 (smtp → telemetry → pools → client + span → messaging). Three commits, per the playbook in rfc/monorepo.md:

Add 'packages/pools/' from commit 'a45d867e…': subtree import from the mirror with full history. The mirror head is the 2.1.2 tag Appwrite already locks, so nothing else in the dependency graph moves.
chore(pools): mirror plumbing: mirror.yml pointed here, README banner refreshed, the Gitpod config dropped; the mirror ruleset was updated by the same absorb run (split app bypass).
refactor: load pools from packages/: root autoload and replace entries, utopia-php/pools dropped from require and from the lock (the six vendored packages that require it, abuse, cache, client, database, messaging, queue, now resolve against the root). Step A of the standard shape: src/Pools and tests/Pools flattened, tests under Utopia\Pools\Tests, phpstan.neon and rector.php made standalone. PHPStan keeps scanDirectories: vendor/swoole/ide-helper (inside the package, so allowed) because the Swoole\Coroutine\Channel generic in Adapter\Swoole only exists in the stubs. Rector is clean on arrival, so production changes are Pint formatting only.

Nothing to hoist: the package's only requirement, utopia-php/telemetry, is already a sibling in packages/. Appwrite imports the namespace in 19 files; root PHPStan is clean on all of them.

Validation

bin/monorepo validate: all packages valid
bin/monorepo check pools: Rector, Pint and PHPStan level max, no baseline
bin/monorepo test pools: 97 tests; the Stack adapter tests (43) pass, the Swoole adapter and waiter tests segfault on this macOS host (Swoole 6 + PHP 8.5) exactly as the untouched mirror code does from utopia-php/monorepo, so the Linux runner decides, as it did for lock and telemetry
vendor/bin/phpunit --testsuite packages --filter 'Utopia\\Pools\\Tests\\Adapter\\StackTest': 43 tests green under the root autoloader; telemetry's 24 still green
composer validate --no-check-publish: existing exact-version warnings only; composer dump-autoload without PSR-4 warnings
bin/monorepo split pools --dry-run: 99a729f7413210ed3e6a45a225ca46a9bc9338f0
git diff --check

Merge and follow-up

Merge with a merge commit, not squash, to preserve the subtree annotation the split continues from.

After merge: confirm Appwrite's Split pushes to utopia-php/pools, then remove packages/pools from utopia-php/monorepo and regenerate its graph in a follow-up PR. One PR is still open on the mirror, utopia-php/pools#30 (stale connection recovery, opened 2026-03-11); the redirect only covers new PRs, so it needs a decision from its owner: re-open here against packages/pools or close.

Part of #13828.

Co-authored-by: Torsten Dittmann <torsten.dittmann@googlemail.com>

Co-authored-by: Christy Jacob <christyjacob4@gmail.com>

Initial PR

- Drop the 17 per-package mirror CI workflows: they were inert in the monorepo and only re-tested, on the mirror, code the monorepo's own matrix already gated pre-merge. absorb now strips all incoming workflows and writes only mirror.yml; the ratchet lint over packages/* (no uses: left to pin) goes too. - Make absorb's mirror ruleset idempotent: update whatever branch ruleset already exists in place instead of skipping on a name clash (the gap that left auth's mirror without the split-app bypass). - Remove the standalone `import` command — unused, and it left a package without mirror.yml/banner/ruleset. import_package() stays as absorb's helper. - Trim absorbing.md/creating.md/README to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

build: hoist baseline rector + phpstan configs to the root

Reuse mirror redirect workflow

docs: enforce documentation style with Vale

docs: centralize CODE_OF_CONDUCT and CONTRIBUTING at the monorepo root

…ctions fix(pools): recover failed pool connections

fix(pools): release the reserved slot when connection creation fails

feat(pools)!: constructor-only configuration, one acquisition budget

fix(pools): hold the owning pool weakly so dropped pools free their resources

refactor(pools,circuit-breaker,storage): drop the deprecated Instrument::lazy() helpers

…ection fix(nats,pools,queue): stop losing work, dedupe enqueues, end duplicate delivery (CLO-4771/4772/4773)

chore: stop committing package lock files

…ters fix(pools): wake waiters when failed borrowers free capacity

…059f4a' git-subtree-dir: packages/pools git-subtree-mainline: 7eab5f1 git-subtree-split: a45d867

Point mirror.yml and the README banner at appwrite/appwrite so PRs and issues opened on the mirror are redirected here, and drop the Gitpod config the root tooling replaces.

Appwrite now autoloads Utopia\Pools from packages/pools and replaces utopia-php/pools so the vendored copy is no longer installed; the six vendored packages that require it resolve against the root. The mirror head is the 2.1.2 tag the lock already resolved, and its only requirement, utopia-php/telemetry, is already a sibling in packages/. Shape follows rfc/monorepo.md step A: src/Pools and tests/Pools are flattened, tests live under Utopia\Pools\Tests, and phpstan.neon and rector.php no longer reach for the old monorepo root configs. PHPStan keeps scanning the package's Swoole stubs for the generic Channel type. Source changes are Pint formatting only.

greptile-apps · 2026-09-22T19:12:09Z

github-actions · 2026-09-22T19:17:58Z

✨ Benchmark results

Comparing main (before) → feat/absorb-pools (after).

Metric	Before	After	Change
🚀 Requests/sec	`196.73`	`196.86`	⚪ `+0.1%`
⏱️ Latency P50	`88.81 ms`	`87.87 ms`	⚪ `-1.1%`
⏱️ Latency P95	`204.07 ms`	`206.31 ms`	⚪ `+1.1%`

Per-scenario breakdown & investigation details

Metrics below reflect the current branch (after). Δ P95 compares against the base.

Scenario	P50 (ms)	P95 (ms)	Requests	RPS	Δ P95 (ms)
API total	`87.87`	`206.31`	`12,483`	`196.86`	`+2.24`
Account	`175.67`	`329.64`	`657`	`11.01`	`+19.1`
TablesDB	`85.12`	`160`	`6,789`	`110.16`	`-1.33`
Storage	`79.79`	`173.16`	`3,285`	`54.58`	`-8.08`
Functions	`126.89`	`248.98`	`1,752`	`29.67`	`+6.22`

Top API waits (after)

API request	Max wait (ms)
account.name.update	`472.48`
functions.create	`430.35`
functions.variables.update	`428.72`
functions.delete	`400.18`
account.prefs.update	`396.8`

CI runs check before test on a fresh checkout, so a phpstan.neon that scans the package's own stubs (pools reads swoole/ide-helper for the generic Channel type) failed with a missing vendor directory. The old monorepo's check installed the package first; do the same.

greptile-apps · 2026-09-22T19:22:37Z

+            // Should only create exactly pool size connections (no race conditions with new implementation)
+            $this->assertSame(5, $connectionCounter, 'Should create exactly 5 connections (pool size)');


Implementation-Coupled Creation Counts

This concurrency test requires the initializer to run exactly once per configured pool slot, so it mirrors the pool's current lazy-creation strategy rather than testing only observable capacity, exclusivity, and reuse. The same brittle assertion appears in the high-concurrency and stress tests. This violates the repository directive that tests assert observable behavior instead of implementation details, and that requirement must be satisfied before merging.

Context Used: Call out and harshly judge implementation-coupled tests. We don't mirror source code, configuration, or version pins in assertions. We test observable behavior; use linters for syntax and schema checks. (source)

Prompt To Fix With AI

This is a comment left during a code review. Path: packages/pools/tests/Adapter/SwooleTest.php Line: 104-105 Comment: **Implementation-Coupled Creation Counts** This concurrency test requires the initializer to run exactly once per configured pool slot, so it mirrors the pool's current lazy-creation strategy rather than testing only observable capacity, exclusivity, and reuse. The same brittle assertion appears in the high-concurrency and stress tests. This violates the repository directive that tests assert observable behavior instead of implementation details, and that requirement must be satisfied before merging. **Context Used:** Call out and harshly judge implementation-coupled tests. We don't mirror source code, configuration, or version pins in assertions. We test observable behavior; use linters for syntax and schema checks. ([source](https://app.greptile.com/review/custom-context?memory=instruction-0)) --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Pre-existing in the imported library at mirror commit a45d867 (the 2.1.2 release Appwrite already runs). An absorb PR relocates the package with its history and does not change library behaviour or tests; production changes here are Pint formatting only, matching #13723, #13798, #13804, #13829 and #13731. Tracked for the phase 8 harvest rather than changed in this PR.

Understood. Since this is unchanged behavior from the imported 2.1.2 library and the absorb PR only relocates it—with production changes limited to formatting—I agree it is out of scope for this PR. Tracking the assertion cleanup for the phase 8 harvest is appropriate; I’m withdrawing this as a merge-blocking finding.

eldadfux and others added 30 commits October 8, 2022 16:17

Initial commit

0cf165b

Project Init based on DB lib

e620b25

Updated README

ef12409

POC

a914177

Added pools, pool and connection

97fc923

Fixed connection ID

3506d0d

Renamed Pools to Group and added tests

63d5121

Added more tests

09f073b

Fixed tests

9b1fb7f

Added more tests

575bd60

Fixed type, updated readme example

9613210

Updated Readme

1be2c71

Updated Readme

a5fbe52

Updated Readme

109299b

Use composer install instead of update

63cc91b

Don't return null on Group get()

052313d

Update src/Pools/Group.php

967ec05

Co-authored-by: Torsten Dittmann <torsten.dittmann@googlemail.com>

Added missing type

3e4060d

Merge branch 'dev' of github.com:utopia-php/pools into dev

f2149af

Added missing types

bb80985

Synced docblocks

ea30e18

Changed reset() to reclaim()

49c8216

Update CONTRIBUTING.md

b603db8

Co-authored-by: Christy Jacob <christyjacob4@gmail.com>

Update README.md

e686272

Co-authored-by: Christy Jacob <christyjacob4@gmail.com>

Added fixes for suggestions

97a6e76

Merge branch 'dev' of github.com:utopia-php/pools into dev

29a1d88

Removed unused container

f04e790

Fixed tests

3a869f3

Merge pull request #1 from utopia-php/dev

5a467a5

Initial PR

Fixed error message

cc47c5d

loks0n and others added 16 commits June 20, 2026 10:45

Merge pull request #40 from utopia-php/feat/rector-hoist

1334616

build: hoist baseline rector + phpstan configs to the root

Merge pull request #48 from utopia-php/refactor/mirror-workflow

163c94d

Reuse mirror redirect workflow

Merge pull request #69 from utopia-php/docs/vale-linter

b2e51f7

docs: enforce documentation style with Vale

Merge pull request #70 from utopia-php/docs/centralize-community-files

cd2b1b9

docs: centralize CODE_OF_CONDUCT and CONTRIBUTING at the monorepo root

Merge pull request #75 from utopia-php/fix/pools-recover-failed-conne…

fd5aa7e

…ctions fix(pools): recover failed pool connections

Merge pull request #93 from utopia-php/fix/pool-slot-leak-on-throwable

2c2ee15

fix(pools): release the reserved slot when connection creation fails

Merge pull request #94 from utopia-php/feat/pools-2-constructor-only

75cd678

feat(pools)!: constructor-only configuration, one acquisition budget

Merge pull request #99 from utopia-php/fix/pools-connection-cycle

48905da

fix(pools): hold the owning pool weakly so dropped pools free their resources

Merge pull request #114 from utopia-php/chore/telemetry-migrations

86d43fc

refactor(pools,circuit-breaker,storage): drop the deprecated Instrument::lazy() helpers

Merge pull request #173 from utopia-php/fix/nats-connection-death-det…

5067d39

…ection fix(nats,pools,queue): stop losing work, dedupe enqueues, end duplicate delivery (CLO-4771/4772/4773)

Merge pull request #194 from utopia-php/chore/no-package-lock-files

bc689b8

chore: stop committing package lock files

Merge pull request #212 from utopia-php/codex/release-safety-pool-wai…

a45d867

…ters fix(pools): wake waiters when failed borrowers free capacity

Add 'packages/pools/' from commit 'a45d867e56de82a2eb6e1eb3ea78d4c2f6…

5f67f6f

…059f4a' git-subtree-dir: packages/pools git-subtree-mainline: 7eab5f1 git-subtree-split: a45d867

chore(pools): mirror plumbing

86e5a61

Point mirror.yml and the README banner at appwrite/appwrite so PRs and issues opened on the mirror are redirected here, and drop the Gitpod config the root tooling replaces.

ChiragAgg5k added the absorb History-preserving package absorption; merge commit required label Sep 22, 2026

ChiragAgg5k mentioned this pull request Sep 22, 2026

Absorb the remaining Utopia libraries into packages/ #13828

Closed

30 of 34 tasks

greptile-apps Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread packages/pools/tests/Scopes/PoolTestScope.php

greptile-apps Bot reviewed Sep 22, 2026

View reviewed changes

loks0n approved these changes Sep 23, 2026

View reviewed changes

ChiragAgg5k merged commit 28b7197 into main Sep 23, 2026
117 of 122 checks passed

ChiragAgg5k deleted the feat/absorb-pools branch September 23, 2026 08:28

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

chore: absorb pools into packages/pools - #13845

chore: absorb pools into packages/pools#13845
ChiragAgg5k merged 161 commits into
mainfrom
feat/absorb-pools

ChiragAgg5k commented Sep 22, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Sep 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot commented Sep 22, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot Sep 22, 2026

Uh oh!

ChiragAgg5k Sep 22, 2026

Uh oh!

greptile-apps Bot Sep 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

		// Should only create exactly pool size connections (no race conditions with new implementation)
		$this->assertSame(5, $connectionCounter, 'Should create exactly 5 connections (pool size)');

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

ChiragAgg5k commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Merge and follow-up

Uh oh!

greptile-apps Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Uh oh!

Uh oh!

github-actions Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Benchmark results

Uh oh!

greptile-apps Bot Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

ChiragAgg5k Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

ChiragAgg5k commented Sep 22, 2026 •

edited

Loading

greptile-apps Bot commented Sep 22, 2026 •

edited

Loading

github-actions Bot commented Sep 22, 2026 •

edited

Loading