{{ message }}
Repository navigation
test(realtime): create documents outside the coroutine in the concurrent traffic test - #13840
Merged
Merged
Conversation
…ent traffic test curl under Swoole's coroutine hook fails on CI without reaching the API, so the six creates never happened and every receiver timed out waiting for events. Race the creates through the client's curl_multi batch instead, keep the five receivers as coroutines, and move every assertion outside the scheduler so a failure is reported instead of killing the process. The same pattern was removed from the client in 3194210. (cherry picked from commit f48b9fe)
Contributor
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
✨ Benchmark resultsComparing
Per-scenario breakdown & investigation detailsMetrics below reflect the current branch (after). Δ P95 compares against the base.
Top API waits (after) |
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testConcurrentRealtimeTrafficCoroutinescreated its six documents with the e2e client from insideCoroutine\run. Under Swoole's coroutine curl hook thosecurl_execcalls fail on CI without ever reaching the API (an instrumented run shows each POST returning in about 1ms with no status code), so the five receivers wait two seconds for events that were never triggered and the process dies withWebSocket\TimeoutException: Client read timeout. This is the same failure mode 3194210 removed from the client's concurrent requests.The test now races the creates through
Client::callConcurrently(curl_multi, no coroutine), keeps the five receivers as coroutines draining the already-buffered frames, and moves every assertion outside the scheduler so a failure is reported instead of killing the process.The flake has been hitting
Tests / E2E / PostgreSQL (dedicated) / Realtimeon main (for example run 35618367153 on 2026-09-21) and blocked #13731 five times in a row today; a main run instrumented the same way failed identically (run 35738423645).Validation
Local PostgreSQL stack: the test passes 3/3 in isolation and inside the full
RealtimeCustomClientTestclass; Pint clean.Part of #13828.