Repository navigation
fix(console): link the new console everywhere and drop the legacy /console scheme #13689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
879f850
891ba49
d16e886
d097daa
9ed2e71
7d1121d
514c9e4
9fd34b7
9800cc1
87e0f9c
2423bb9
7cc7063
db029c3
4ed17e6
8788b6b
264f030
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -242,10 +242,10 @@ | |
| 'filter' => '' | ||
| ], | ||
| [ | ||
| 'name' => '_APP_CONSOLE_URL_SCHEME', | ||
| 'description' => 'Console URL scheme used when the backend generates links to the console (OAuth callbacks, emails, error page CTAs, VCS comments). Set to \'root\' for the new console served at the root path (appwrite/new), or \'legacy\' for the older console served under the /console path prefix. The default value is \'legacy\'.', | ||
| 'introduction' => '2.0.0', | ||
| 'default' => 'legacy', | ||
| 'name' => '_APP_CONSOLE_URL', | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we 100% certain we need new variable? Can we not reuse some existing one? if so, why not? |
||
| 'description' => 'Origin of the Appwrite console web app, such as https://console.example.com, used when the backend generates links to the console (OAuth callbacks, emails, error page CTAs, VCS comments and commit statuses). Set it when the console is served on a different host than the API. When empty, links use _APP_CONSOLE_DOMAIN (or _APP_DOMAIN) over https, or over http when _APP_OPTIONS_FORCE_HTTPS is disabled.', | ||
| 'introduction' => '2.2.1', | ||
| 'default' => '', | ||
| 'required' => false, | ||
| 'question' => '', | ||
| 'filter' => '' | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Throughout entire PR, we touched MANY flows. Lets QA them manually, to make sure there is no regression, nothing breaks. |

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets check who added this variable, and confirm with them that its OK to remove it with this PR