{{ message }}
fix: return ISO8601 session expire from updateSession - #12891
Merged
Meldiron merged 2 commits intoAug 3, 2026
Conversation
Wrap expire and providerAccessTokenExpiry with DateTime::formatTz so PATCH /account/sessions matches GET and create-session responses (appwrite#8447).
Contributor
Meldiron
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Fixes #8447 by wrapping
expireandproviderAccessTokenExpirywithDateTime::formatTz()inPATCH /v1/account/sessions/:sessionId.Previously,
updateSessionreturned the DB datetime format (Y-m-d H:i:s.v) fromDateTime::addSeconds(), whileGETsession returned ISO8601 via the datetime decode filter. Create-session paths already usedformatTz; this aligns update with that pattern so SDK clients can deserializeexpireconsistently.Test Plan
testRefreshEmailPasswordSessionto assert PATCH (and subsequent GET)expireis ISO8601 viaDatetimeValidatorandY-m-d\TH:i:s.uPdocker compose exec appwrite vendor/bin/phpunit --filter testRefreshEmailPasswordSession(passed)Related PRs and Issues
Checklist