{{ message }}
fix: add CORS headers to GraphQL responses#11987
Open
Syroxivoss wants to merge 2 commits intoappwrite:1.9.xfrom
Open
fix: add CORS headers to GraphQL responses#11987Syroxivoss wants to merge 2 commits intoappwrite:1.9.xfrom
Syroxivoss wants to merge 2 commits intoappwrite:1.9.xfrom
Conversation
Contributor
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes GraphQL POST responses so they include the same CORS/security headers already returned by the preflight path.
Root cause:
app/controllers/general.phponly applied to theapiandwebgroupsgraphqlgroup, so successful/v1/graphqlPOST responses skipped that header injection pathThis PR:
graphqlgroup in the global CORS/security init hook/graphqlresponseTest Plan
Verified the edited files have no editor diagnostics in this environment.
Full Docker E2E execution could not be run here because the
dockerCLI is unavailable.Recommended focused validation in a full local Appwrite environment:
docker compose exec appwrite test tests/e2e/Services/GraphQL/ContentTypeTest.php --filter=IncludesCorsHeaders
Related PRs and Issues
Closes #11959