Add travis to run pylint and unit tests by KazuCocoa · Pull Request #239 · appium/python-client · GitHub
Skip to content

Add travis to run pylint and unit tests#239

Merged
imurchie merged 6 commits into
appium:masterfrom
KazuCocoa:add-travis-pylint
Aug 12, 2018
Merged

Add travis to run pylint and unit tests#239
imurchie merged 6 commits into
appium:masterfrom
KazuCocoa:add-travis-pylint

Conversation

@KazuCocoa

@KazuCocoa KazuCocoa commented Aug 8, 2018

Copy link
Copy Markdown
Member

This PR is proposal.
📝 I'll ask recommended preferences in python channel


Current this repository has no travis preference. No pylint, but this repository has a few unit tests as well. https://pylint.readthedocs.io/en/latest/technical_reference/features.html provide some compatibility checking for Python 2 and 3.

So, what about adding travis and pylint?


What I did

  • Add travis.yml
  • Add template of .pylintrc

we can ignore

  • missing-docstring
  • empty-docstring
  • too-few-public-methods
  • invalid-name
  • duplicate-code

Error

  • No
  • All unit tests are passed

Comment thread .pylintrc

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a couple of lines from here. Other lines are from a template.

@KazuCocoa KazuCocoa changed the title [WIP]Add travis and pylint Add travis and pylint Aug 10, 2018
@KazuCocoa KazuCocoa changed the title Add travis and pylint Add travis to run pylint and unit tests Aug 10, 2018
@KazuCocoa

Copy link
Copy Markdown
Member Author

@imurchie or @jlipps
Could you enable travis for this repository when you have a time?

After this PR, we can run pylint and unit tests on CI

@imurchie imurchie merged commit 098581a into appium:master Aug 12, 2018
@imurchie

Copy link
Copy Markdown
Collaborator

Enabled. Use further PRs to fix the build.

@KazuCocoa

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants