feat: Add ability to set multiple settings by valfirst · Pull Request #1409 · appium/java-client · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/main/java/io/appium/java_client/HasSettings.java
7 changes: 5 additions & 2 deletions src/main/java/io/appium/java_client/MobileCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -481,8 +481,11 @@ public static ImmutableMap<String, Object> prepareArguments(String[] params,
}

public static Map.Entry<String, Map<String, ?>> setSettingsCommand(String setting, Object value) {
return new AbstractMap.SimpleEntry<>(SET_SETTINGS, prepareArguments("settings",
prepareArguments(setting, value)));
return setSettingsCommand(prepareArguments(setting, value));
}

public static Map.Entry<String, Map<String, ?>> setSettingsCommand(Map<String, Object> settings) {
return new AbstractMap.SimpleEntry<>(SET_SETTINGS, prepareArguments("settings", settings));
}

/**
Expand Down
21 changes: 21 additions & 0 deletions src/test/java/io/appium/java_client/android/SettingTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
import org.junit.Test;

import java.time.Duration;
import java.util.EnumMap;
import java.util.HashMap;
import java.util.Map;

import static org.junit.Assert.assertEquals;

Expand Down Expand Up @@ -103,6 +106,24 @@ public class SettingTest extends BaseAndroidTest {
.get("shouldUseCompactResponses"));
}

@Test public void setMultipleSettings() {
EnumMap<Setting, Object> enumSettings = new EnumMap<>(Setting.class);
enumSettings.put(Setting.IGNORE_UNIMPORTANT_VIEWS, true);
enumSettings.put(Setting.ELEMENT_RESPONSE_ATTRIBUTES, "type,label");
driver.setSettings(enumSettings);
Map<String, Object> actual = driver.getSettings();
assertEquals(true, actual.get(Setting.IGNORE_UNIMPORTANT_VIEWS.toString()));
assertEquals("type,label", actual.get(Setting.ELEMENT_RESPONSE_ATTRIBUTES.toString()));

Map<String, Object> mapSettings = new HashMap<>();
mapSettings.put(Setting.IGNORE_UNIMPORTANT_VIEWS.toString(), false);
mapSettings.put(Setting.ELEMENT_RESPONSE_ATTRIBUTES.toString(), "");
driver.setSettings(mapSettings);
actual = driver.getSettings();
assertEquals(false, actual.get(Setting.IGNORE_UNIMPORTANT_VIEWS.toString()));
assertEquals("", actual.get(Setting.ELEMENT_RESPONSE_ATTRIBUTES.toString()));
}

private void assertJSONElementContains(Setting setting, long value) {
assertEquals(driver.getSettings().get(setting.toString()), value);
}
Expand Down
27 changes: 23 additions & 4 deletions src/test/java/io/appium/java_client/ios/SettingTest.java