build: update gradle and fix jitpack build failures by SrinivasanTarget · Pull Request #1389 · appium/java-client · GitHub
Skip to content

build: update gradle and fix jitpack build failures #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SrinivasanTarget merged 2 commits into from
Sep 7, 2020
Merged

build: update gradle and fix jitpack build failures #1389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7d2478
update gradle and fix jitpack failures
SrinivasanTarget Sep 6, 2020
9dc11be
fix compilation issues
SrinivasanTarget Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 38 additions & 44 deletions build.gradle
View file
Open in desktop
4 changes: 2 additions & 2 deletions src/test/java/io/appium/java_client/service/local/ServerBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public void checkAbilityToStartServiceUsingCapabilities() {
caps.setCapability(APP_PACKAGE, "io.appium.android.apis");
caps.setCapability(APP_ACTIVITY, ".view.WebView1");
caps.setCapability(APP, apiDemosApk().toAbsolutePath().toString());
caps.setCapability(CHROMEDRIVER_EXECUTABLE, chromeManager.getBinaryPath());
caps.setCapability(CHROMEDRIVER_EXECUTABLE, chromeManager.getDownloadedDriverPath());

service = new AppiumServiceBuilder().withCapabilities(caps).build();
service.start();
Expand All @@ -184,7 +184,7 @@ public void checkAbilityToStartServiceUsingCapabilitiesAndFlags() {
caps.setCapability("quotes", "\"'");
caps.setCapability("goog:chromeOptions",
ImmutableMap.of("env", ImmutableMap.of("test", "value"), "val2", 0));
caps.setCapability(CHROMEDRIVER_EXECUTABLE, chromeManager.getBinaryPath());
caps.setCapability(CHROMEDRIVER_EXECUTABLE, chromeManager.getDownloadedDriverPath());

service = new AppiumServiceBuilder()
.withArgument(CALLBACK_ADDRESS, testIP)
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/io/appium/java_client/service/local/StartingAppLocallyTest.java
View file
Open in desktop