Add the missing settings which introduced in appium 1.12 and 1.13 by takeyaqa · Pull Request #1156 · appium/java-client · GitHub
Skip to content

Add the missing settings which introduced in appium 1.12 and 1.13 #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mykola-mokhnach merged 1 commit into from
Jun 14, 2019
Merged

Add the missing settings which introduced in appium 1.12 and 1.13 #1156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/io/appium/java_client/Setting.java
View file
Open in desktop
14 changes: 13 additions & 1 deletion src/main/java/io/appium/java_client/android/HasAndroidSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ default HasAndroidSettings setShouldUseCompactResponses(boolean enabled) {

/**
* Which attributes should be returned if compact responses are disabled.
* It works only if shouldUseCompactResponses is false. Defaults to "type,label" string.
* It works only if shouldUseCompactResponses is false. Defaults to "" (empty string).
*
* @param attrNames The comma-separated list of fields to return with each element.
* @return self instance for chaining
Expand Down Expand Up @@ -165,4 +165,16 @@ default HasAndroidSettings enableNotificationListener(boolean enabled) {
setSetting(Setting.ENABLE_NOTIFICATION_LISTENER, enabled);
return this;
}

/**
* Whether to enable or disable shutdown the server through
* the broadcast receiver on ACTION_POWER_DISCONNECTED.
*
* @param enabled Either true or false. The default value if true.
* @return self instance for chaining
*/
default HasAndroidSettings shutdownOnPowerDisconnect(boolean enabled) {
setSetting(Setting.SHUTDOWN_ON_POWER_DISCONNECT, enabled);
return this;
}
}
14 changes: 13 additions & 1 deletion src/main/java/io/appium/java_client/ios/HasIOSSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ default HasIOSSettings setShouldUseCompactResponses(boolean enabled) {

/**
* Which attributes should be returned if compact responses are disabled.
* It works only if shouldUseCompactResponses is set to false. Defaults to an empty string.
* It works only if shouldUseCompactResponses is set to false. Defaults to "type,label" string.
*
* @param attrNames The comma-separated list of fields to return with each element.
* @return self instance for chaining
Expand Down Expand Up @@ -95,4 +95,16 @@ default HasIOSSettings setScreenshotQuality(int quality) {
setSetting(Setting.SCREENSHOT_QUALITY, quality);
return this;
}

/**
* The scale of screenshots in range 1..100.
* The default value is 100, no scaling
*
* @param scale An integer in range 1..100. The default value is 100.
* @return self instance for chaining
*/
default HasIOSSettings setMjpegScalingFactor(int scale) {
setSetting(Setting.MJPEG_SCALING_FACTOR, scale);
return this;
}
}
48 changes: 48 additions & 0 deletions src/test/java/io/appium/java_client/android/SettingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,54 @@ public class SettingTest extends BaseAndroidTest {
assertJSONElementContains(Setting.WAIT_FOR_SELECTOR_TIMEOUT, 1000);
}

@Test public void testNormalizeTagNames() {
assertEquals(false, driver.getSettings()
.get(Setting.NORMALIZE_TAG_NAMES.toString()));
driver.normalizeTagNames(true);
assertEquals(true, driver.getSettings()
.get(Setting.NORMALIZE_TAG_NAMES.toString()));
}

@Test public void testSetShouldUseCompactResponses() {
assertEquals(true, driver.getSettings()
.get(Setting.SHOULD_USE_COMPACT_RESPONSES.toString()));
driver.setShouldUseCompactResponses(false);
assertEquals(false, driver.getSettings()
.get(Setting.SHOULD_USE_COMPACT_RESPONSES.toString()));
}

@Test public void testSetElementResponseAttributes() {
assertEquals("", driver.getSettings()
.get(Setting.ELEMENT_RESPONSE_ATTRIBUTES.toString()));
driver.setElementResponseAttributes("type,label");
assertEquals("type,label", driver.getSettings()
.get(Setting.ELEMENT_RESPONSE_ATTRIBUTES.toString()));
}

@Test public void testAllowInvisibleElements() {
assertEquals(false, driver.getSettings()
.get(Setting.ALLOW_INVISIBLE_ELEMENTS.toString()));
driver.allowInvisibleElements(true);
assertEquals(true, driver.getSettings()
.get(Setting.ALLOW_INVISIBLE_ELEMENTS.toString()));
}

@Test public void testEnableNotificationListener() {
assertEquals(true, driver.getSettings()
.get(Setting.ENABLE_NOTIFICATION_LISTENER.toString()));
driver.enableNotificationListener(false);
assertEquals(false, driver.getSettings()
.get(Setting.ENABLE_NOTIFICATION_LISTENER.toString()));
}

@Test public void testShutdownOnPowerDisconnect() {
assertEquals(true, driver.getSettings()
.get(Setting.SHUTDOWN_ON_POWER_DISCONNECT.toString()));
driver.shutdownOnPowerDisconnect(false);
assertEquals(false, driver.getSettings()
.get(Setting.SHUTDOWN_ON_POWER_DISCONNECT.toString()));
}

private void assertJSONElementContains(Setting setting, long value) {
assertEquals(driver.getSettings().get(setting.toString()), value);
}
Expand Down
74 changes: 74 additions & 0 deletions src/test/java/io/appium/java_client/ios/SettingTest.java
View file
Open in desktop