refactor!: remove unused config properties by vdusek · Pull Request #978 · apify/crawlee-python · GitHub
Skip to content

refactor!: remove unused config properties #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
Feb 12, 2025
Merged

refactor!: remove unused config properties #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/upgrading/upgrading_to_v0x.md
View file
Open in desktop
4 changes: 1 addition & 3 deletions src/crawlee/_log_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@
def get_configured_log_level() -> int:
config = service_locator.get_configuration()

verbose_logging_requested = 'verbose_log' in config.model_fields_set and config.verbose_log

if 'log_level' in config.model_fields_set:
if config.log_level == 'DEBUG':
return logging.DEBUG
Expand All @@ -53,7 +51,7 @@ def get_configured_log_level() -> int:

assert_never(config.log_level)

if sys.flags.dev_mode or verbose_logging_requested:
if sys.flags.dev_mode:
return logging.DEBUG

return logging.INFO
Expand Down
25 changes: 0 additions & 25 deletions src/crawlee/configuration.py
View file
Open in desktop