{{ message }}
Repository navigation
test: deflake shared timeout expiry test - #2345
Merged
Merged
Conversation
vdusek
marked this pull request as ready for review
October 21, 2026 06:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

test_shared_timeout_expiresfailed on a macOS runner withassert 2.3198758749999797 < 0.3(run). TheTimeoutErrorwas raised as expected, but the event loop stalled for about 2 s, and the wall-clock assertion counted the stall.The test now runs a 10 s body against the 0.1 s budget and drops the wall-clock bound. If the budget didn't cut the body short, the sleep would finish and
pytest.raiseswould fail. A local plugin that blocks the loop for 2.3 s made the old test fail 20/20 and the new one pass 20/20.✍️ Drafted by Claude Code