test: deflake shared timeout expiry test by vdusek · Pull Request #2345 · apify/crawlee-python · GitHub
Skip to content

test: deflake shared timeout expiry test - #2345

Merged
vdusek merged 1 commit into
masterfrom
test/deflake-shared-timeout-expires
Oct 21, 2026
Merged

vdusek merged 1 commit into
masterfrom
test/deflake-shared-timeout-expires

Conversation

@vdusek

@vdusek vdusek commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

test_shared_timeout_expires failed on a macOS runner with assert 2.3198758749999797 < 0.3 (run). The TimeoutError was raised as expected, but the event loop stalled for about 2 s, and the wall-clock assertion counted the stall.

The test now runs a 10 s body against the 0.1 s budget and drops the wall-clock bound. If the budget didn't cut the body short, the sleep would finish and pytest.raises would fail. A local plugin that blocks the loop for 2.3 s made the old test fail 20/20 and the new one pass 20/20.

✍️ Drafted by Claude Code

@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Oct 21, 2026
@vdusek vdusek self-assigned this Oct 21, 2026
@vdusek
vdusek marked this pull request as ready for review October 21, 2026 06:44
@vdusek
vdusek requested a review from Mantisus October 21, 2026 06:44
@apify-service-account apify-service-account added the tested Temporary label used only programatically for some analytics. label Oct 21, 2026
@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

@Mantisus Mantisus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apify-approval-mirror apify-approval-mirror Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirroring approval from @Mantisus.

@vdusek
vdusek merged commit 1603c1c into master Oct 21, 2026
47 of 49 checks passed
@vdusek
vdusek deleted the test/deflake-shared-timeout-expires branch October 21, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants