{{ message }}
Repository navigation
refactor: RecoverableState abstraction - #1172
Merged
Merged
Conversation
janbuchar
force-pushed
the
persistent-object-abstraction
branch
from
April 24, 2025 09:38
1186ca2 to
c1f920c
Compare
janbuchar
commented
Apr 24, 2025
janbuchar
commented
Apr 24, 2025
janbuchar
marked this pull request as ready for review
April 24, 2025 14:08
Pijukatel
reviewed
Apr 25, 2025
This comment has been minimized.
This comment has been minimized.
janbuchar
commented
Apr 28, 2025
Mantisus
reviewed
Apr 28, 2025
vdusek
reviewed
Apr 29, 2025
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
Nice! I like it, and its usage. Just a few minor notes & questions...
vdusek
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

StatisticsandSessionPool).RequestList#99Key Changes
Introduced a new
RecoverableStatehelper class that:KeyValueStoreRefactored existing components to use the new abstraction:
SessionPoolto useRecoverableStatefor state managementStatisticsto useRecoverableStatefor state managementKeyValueStoreto useRecoverableStatefor autosaved valuesBenefits