{{ message }}
Repository navigation
docs: add GCP Cloud Run deployment guide - #1167
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new deployment guide for GCP Cloud Run along with example code and necessary dependency updates.
- Updates the sidebar to link to the new Cloud Run guide.
- Adds "litestar" as a dependency in pyproject.toml.
- Provides a new example in Python for deploying on GCP Cloud Run.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- docs/deployment/google_cloud_run.mdx: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vdusek
requested changes
Apr 23, 2025
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
Could you please add links to the relevant GCP products we're covering in the guide?
I believe we're referring to:
- GCP Cloud Run - https://cloud.google.com/run
- GCP Cloud Run functions - https://cloud.google.com/functions
Also, I suggest adjust the page titles and metadata as follows:
---
id: gcp-cloud-run
title: Cloud Run
description: Prepare your crawler to run in Cloud Run on Google Cloud Platform.
---
---
id: gcp-cloud-run-functions
title: Cloud Run functions
description: Prepare your crawler to run in Cloud Run functions on Google Cloud Platform.
---
This would result in this structure in the navigation:
- Deploy to Google Cloud
- Cloud Run functions
- Cloud Run
vdusek
requested changes
Apr 23, 2025
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
Could we please add a brief introduction at the beginning of the pages with the explanation of what service we are going to use and what its purpose is?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues