{{ message }}
Repository navigation
docs: Add to the documentation guide of login with HttpCrawler and PlaywrightCrawler - #1142
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- docs/examples/crawler_login.mdx: Language not supported
Comments suppressed due to low confidence (1)
docs/examples/code_examples/http_login.py:61
- [nitpick] Consider using consistent cookie naming conventions. For example, use 'userId' instead of 'userID' to align with typical camelCase styles used in cookie naming.
context.session.cookies.set(name='userID', value=user_id)
HttpCrawler and PlaywrightCrawler``HttpCrawler and PlaywrightCrawler
janbuchar
approved these changes
Apr 8, 2025
janbuchar
left a comment
janbuchar
left a comment
Collaborator
There was a problem hiding this comment.
It's great that we're getting some coverage of this, thank you!
vdusek
requested changes
Apr 8, 2025
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
Nice! Just a few comments...
Pijukatel
approved these changes
Apr 8, 2025
Co-authored-by: Jan Buchar <Teyras@gmail.com> Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
Mantisus
changed the title
HttpCrawler and PlaywrightCrawlerHttpCrawler and PlaywrightCrawler
vdusek
added
the
t-tooling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HttpCrawlerandPlaywrightCrawlerIssues