{{ message }}
Repository navigation
feat: add an internal HttpClient to be used in send_request for PlaywrightCrawler using APIRequestContext bound to the browser context - #1134
Merged
Conversation
Collaborator
Author
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
tests/unit/crawlers/_playwright/test_playwright_crawler.py:486
- Ensure that send_request_response.read() is decoded (e.g. using .decode('utf-8')) before passing it to json.loads to avoid potential type errors when parsing bytes.
check_data['send_request'] = dict(json.loads(send_request_response.read()))
janbuchar
reviewed
Apr 8, 2025
Mantisus
changed the title
send_request for PlaywrightCrawler using APIRequestContext bound to the browser contextHttpClient to be used in send_request for PlaywrightCrawler using APIRequestContext bound to the browser context
janbuchar
reviewed
Apr 23, 2025
janbuchar
left a comment
janbuchar
left a comment
Collaborator
There was a problem hiding this comment.
Nice, just a couple of nits 🙂
janbuchar
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HttpClientimplementation forPlaywrightCrawlerusing theAPIRequestContextfromPlaywright. This ensures that HTTP requests use the same proxies as the browser context.Issues
HttpClientimplementation #928