fix: Only log any error that happens during log redirection by Pijukatel · Pull Request #866 · apify/apify-client-python · GitHub
Skip to content

fix: Only log any error that happens during log redirection#866

Merged
Pijukatel merged 3 commits into
masterfrom
only-log-errors-on-log-redirection
Jun 18, 2026
Merged

fix: Only log any error that happens during log redirection#866
Pijukatel merged 3 commits into
masterfrom
only-log-errors-on-log-redirection

Conversation

@Pijukatel

@Pijukatel Pijukatel commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Description

Issues

Closes: #864

@github-actions github-actions Bot added this to the 143rd sprint - Tooling team milestone Jun 18, 2026
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Jun 18, 2026
@Pijukatel Pijukatel changed the title fix: Only log any error that happens during log redirection. fix: Only log any error that happens during log redirection Jun 18, 2026
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

@Pijukatel Pijukatel force-pushed the only-log-errors-on-log-redirection branch from e5b7d79 to ac80143 Compare June 18, 2026 12:39
@Pijukatel Pijukatel requested a review from barjin June 18, 2026 12:57
@Pijukatel Pijukatel marked this pull request as ready for review June 18, 2026 12:57

@barjin barjin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested as part of triaging apify/impit#482 👍

Thank you, @Pijukatel !

@Pijukatel Pijukatel merged commit a2cc987 into master Jun 18, 2026
27 checks passed
@Pijukatel Pijukatel deleted the only-log-errors-on-log-redirection branch June 18, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update client to handle new errors from impit

3 participants