{{ message }}
fix: Preserve count=0 in RunClient's charge#751
Merged
Conversation
vdusek
added
adhoc
github-actions
Bot
added
the
tested
The billing endpoint body was built with `count or 1`, which silently rewrote a legitimate `count=0` to `count=1` — on a pay-per-event endpoint, the difference is financially material. Use an explicit `None` check instead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
force-pushed
the
fix/run-charge-preserve-zero-count
branch
from
463e742 to
0faf061
Compare
Pijukatel
requested changes
Apr 27, 2026
Contributor
There was a problem hiding this comment.
Why don't we fix it here?
count: int = 1,
Per review on PR #751, replace `count: int | None = None` + sentinel check with a plain `count: int = 1` default, so `0` is preserved naturally and the `None` branch disappears. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
changed the title
vdusek
changed the title
Pijukatel
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunClient.charge(sync + async) built the request body with'count': count or 1. Becauseortreats0as falsy, a caller passingcount=0— e.g.count=len(batch)for an empty batch, or a defensive no-op — was silently sent ascount=1. On a pay-per-event billing endpoint that's a real overcharge, not a cosmetic bug.Fix
Changed the signature from
count: int | None = Nonetocount: int = 1and passcountthrough to the request body unchanged.0now reaches the server as0; the default1is expressed in the signature instead of via a fallback.Docstring updated to reflect the new contract.
Tests
tests/unit/test_run_charge.pyparametrizes the sync and async clients overcountvalues0,1,5and asserts the value lands in the request body verbatim. The0case fails onmasterand passes here.