{{ message }}
Repository navigation
fix(jsonapi): declare type: object on JSON:API resource schemas - #8724
Open
ousamabenyounes wants to merge 1 commit into
Open
ousamabenyounes wants to merge 1 commit into
ousamabenyounes wants to merge 1 commit into
Conversation
ousamabenyounes
changed the title
*.jsonapi) have properties but no `typ
ousamabenyounes
force-pushed
the
fix/issue-8701
branch
from
October 16, 2026 22:38
18874ef to
e8533af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON:API resource schemas were emitted with
propertiesbut notype, so aconsumer validating against them could not tell the schema describes an object.
The test, on 5.0 without the two-line fix:
With the fix:
src/JsonApi/Tests/JsonSchema/SchemaFactoryTest.phpcarries the assertions;testErrorSchemaIsAnObjectis new and covers the error schema path from #8701.