fix(laravel): pass a factory to for() in NullableBelongsToTest by Maxcastel · Pull Request #8717 · api-platform/core · GitHub
Skip to content

fix(laravel): pass a factory to for() in NullableBelongsToTest - #8717

Open
Maxcastel wants to merge 1 commit into
api-platform:5.0from
Maxcastel:fix/laravel-phpstan-morph-factory
Open

Maxcastel wants to merge 1 commit into
api-platform:5.0from
Maxcastel:fix/laravel-phpstan-morph-factory

Conversation

@Maxcastel

Copy link
Copy Markdown
Contributor

Fixes the Laravel PHPStan error introduced in #8666 (085ee44):

Error: Parameter #1 $factory of method Illuminate\Database\Eloquent\Factories\Factory<Illuminate\Database\Eloquent\Model>::for() expects Illuminate\Database\Eloquent\Factories\Factory|Illuminate\Database\Eloquent\Model, Illuminate\Database\Eloquent\Collection<int, Illuminate\Database\Eloquent\Model>|Illuminate\Database\Eloquent\Model given.
 ------ ----------------------------------------------------------------------- 
  Line   Tests/NullableBelongsToTest.php                                        
 ------ ----------------------------------------------------------------------- 
  73     Parameter #1 $factory of method                                        
         Illuminate\Database\Eloquent\Factories\Factory<Illuminate\Database\El  
         oquent\Model>::for() expects Illuminate\Database\Eloquent\Factories\F  
         actory|Illuminate\Database\Eloquent\Model,                             
         Illuminate\Database\Eloquent\Collection<int, Illuminate\Database\Eloq  
         uent\Model>|Illuminate\Database\Eloquent\Model given.                  
         🪪  argument.type                                                      
 ------ ----------------------------------------------------------------------- 

create() returns Collection|Model, which for() doesn't accept. Passing the factory directly fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant