{{ message }}
Repository navigation
Conversation
Shiro 2 DefaultHashService rejects SHA-1, so LdapRealm.createAuthenticationInfo threw UnsupportedOperationException and every LDAP login failed. Hash with SHA-256 and 50,000 iterations, matching the credentials matcher.
zeotuan
changed the title
zeotuan
marked this pull request as ready for review
October 21, 2026 10:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Since the Shiro 2 upgrade (#5293),
LdapRealmcannot authenticate anyone.createAuthenticationInfohashes the credentials with SHA-1, which Shiro 2DefaultHashServiceno longer supports:Change:
SHA-256and 50,000 iterations.HashedCredentialsMatcher, so the matcher and the stored hash agree.The hash is only used in memory to compare the submitted password with the cached authentication info, so nothing persisted is affected.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
How should this be tested?
LdapRealmTest.testAuthenticationInfoCredentialsMatch: the correct password matches, a wrong one does not. Fails on master with the exception above../mvnw package -pl zeppelin-server --am -Dtest='LdapRealm*Test' -Dsurefire.failIfNoSpecifiedTests=falseScreenshots (if appropriate)
N/A
Questions: