{{ message }}
[MINOR] refactor: use general method to check the remote storage existence#980
Merged
Conversation
roryqi
changed the title
Contributor
|
lgtm, but looks like the test for tez is failed? |
Member
Author
|
Could you help check the Tez unit test failure? @lifeSo I think this is not related with this PR. |
Contributor
|
@lifeSo Could you take a look at the failure test? If it is a flaky test, you can create an issue to track it and try to solve it. |
Contributor
kaijchen
reviewed
Jul 17, 2023
| ShuffleWriteClient shuffleWriteClient) { | ||
| RemoteStorageInfo remoteStorage = defaultRemoteStorage; | ||
| if (requireRemoteStorage(storageType)) { | ||
| if (StorageType.withRemoteStorage(StorageType.valueOf(storageType))) { |
Member
There was a problem hiding this comment.
Check storageType != null here?
The test fails because storageType is null.
roryqi
pushed a commit
that referenced
this pull request
Jul 17, 2023
…rTest (#1015) ### What changes were proposed in this pull request? Add storage type configs in TezRemoteShuffleManagerTest ### Why are the changes needed? StorageType defaults to null, which blocks #980. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Tested with #980.
Contributor
|
@zhengchenyu @lifeSo @bin41215 Could you help take a look at the failure case? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In #259 , we introduce some general method to check the storage types. So
this patch is to refactor the remaining part of this.
Why are the changes needed?
Refactor to optimize the remote storage checking.
Does this PR introduce any user-facing change?
No.
How was this patch tested?